Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1679 : If the bottom of the overlay panel is close to editor bottom, it adds a vertical overflow after toggling an option #2845

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kusuma04-dev
Copy link
Contributor

closes apache/incubator-kie-issues#1679 - If the bottom of the overlay panel is close to editor bottom, it adds a vertical overflow after toggling an option

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I am not sure what should be my review (approve/not appprove) because:

On m machine by default the scrollbar is needed. Since the ticket was created, we added an entry into overlay panel (evaluation highlights) and also this maybe related to:

  • user screen resolution
  • browser setup, for example I am using tabs in the top , so the space for webpage is smaller

In other words, in my setup the scrollbar is not needed only if I turn browser into full screen mode.

Screenshot 2025-01-10 090626

@ljmotta
Copy link
Contributor

ljmotta commented Jan 10, 2025

@jomarko Please zoom out to see the issue.
@Kusuma04-dev I still see the issue here in my machine. Please, remember that the overlay panel should be close to the bottom end of the editor.

@Kusuma04-dev
Copy link
Contributor Author

@jomarko Please zoom out to see the issue. @Kusuma04-dev I still see the issue here in my machine. Please, remember that the overlay panel should be close to the bottom end of the editor.

Hi @ljmotta , Can you please check it once and if it is still there we can connect once to see the issue as i am not seeing the issue on my machine now.

@Kusuma04-dev Kusuma04-dev requested a review from jomarko January 13, 2025 06:02
@jomarko
Copy link
Contributor

jomarko commented Jan 13, 2025

@ljmotta should I use browser zoom feature or editor zoom feature?

@ljmotta
Copy link
Contributor

ljmotta commented Jan 13, 2025

@Kusuma04-dev Which browser are you using? Maybe you can't reproduce because of that. Now, the behavior is different.

bug-overlay.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants